Merged
Conversation
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
The ask agent was removed in 395e956. The special-case fallback (ask → auto → exec) in the catch block is now dead code since no request can arrive with effectiveAgentId === 'ask'. The migration in that same PR already remaps persisted 'ask' selections to 'auto'. Simplify the catch block to always fall back to exec directly.
…essage, createBashOverflowTool)
mux-bot
bot
force-pushed
the
auto-cleanup
branch
from
838c846 to
33d5ad3
Compare
ethanndickson
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Periodic auto-cleanup PR. Each commit is an independent, behavior-preserving refactor found by scanning recent
maincommits.Current cleanup
Remove dead ask-agent fallback from agentResolution — The ask agent was removed in 395e956 (#3047). The special-case fallback path (
ask → auto → exec) in the agent definition loader's catch block is now dead code, since the migration in that same PR already remaps persistedaskselections toautobefore this code path is reached. Simplified the catch block to always fall back toexecdirectly (−8 lines).Validation
make static-checkpasses (ESLint, TypeScript, Prettier)Auto-cleanup checkpoint: fda7812
Generated with
mux• Model:anthropic:claude-opus-4-6• Thinking:xhigh• Cost:N/A