🤖 fix: respect direct OpenAI voice routing#3090
Merged
Conversation
Respect provider route priority when choosing the voice transcription backend. --- _Generated with `mux` • Model: `openai:gpt-5.4` • Thinking: `xhigh` • Cost: `$unknown`_ <!-- mux-attribution: model=openai:gpt-5.4 thinking=xhigh costs=unknown -->
Collaborator
Author
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Voice transcription now follows the same routing preference as OpenAI models, so putting Direct ahead of Mux Gateway in Settings keeps voice input on the direct OpenAI transcription endpoint.
Background
VoiceServicehardcoded a gateway-first choice whenever both a Mux Gateway token and an OpenAI API key were present. That ignored Provider settings, where users can prefer direct routing for OpenAI, and made voice input unexpectedly go through Mux Gateway.Implementation
openai:whisper-1through the shared routing resolver using the savedroutePriority/routeOverridesValidation
bun test src/node/services/voiceService.test.tsmake typecheckmake static-checkRisks
Low and localized to voice transcription backend selection. The change only affects whether voice requests use direct OpenAI or Mux Gateway when both are configured.
Generated with
mux• Model:openai:gpt-5.4• Thinking:xhigh• Cost:$unknown