🤖 fix: align sidebar parent/sub-agent connectors#3129
Merged
Conversation
Collaborator
Author
|
@codex review |
ammario
approved these changes
Apr 5, 2026
Derive sidebar connector geometry from shared leading-slot layout so the default parent/sub-agent rail lines up with both status indicators. Add focused geometry tests to keep the alignment stable. --- _Generated with `mux` • Model: `openai:gpt-5.4` • Thinking: `xhigh` • Cost: `$6.76`_ <!-- mux-attribution: model=openai:gpt-5.4 thinking=xhigh costs=6.76 -->
ammar-agent
force-pushed
the
fix/subagent-sidebar-connector-alignment
branch
from
3ed9ca3 to
d6e8793
Compare
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Derive the left-sidebar sub-agent connector from shared sidebar geometry so the default parent→child rail lands on both status indicators instead of relying on disconnected offsets.
Background
The connector between a parent agent row and its sub-agent rows had drifted out of alignment because the rail and elbow geometry were encoded with hardcoded offsets that were no longer tied to the actual leading status-slot centers. That made the connector fragile whenever surrounding row layout changed.
Implementation
sidebarItemLayout.tsto centralize sidebar padding and leading-slot geometryAgentListItemto compute the parent rail and child endpoint from that shared layout instead of ad hoc offsetsSubAgentListItemto draw the elbow from explicit x-coordinates, which makes the default connector alignment correct by constructionTaskGroupListItemso grouped rows stay on the same indentation gridValidation
make static-checkbun test src/browser/components/sidebarItemLayout.test.ts src/browser/components/AgentListItem/SubAgentListItem.test.tsx src/browser/components/AgentListItem/AgentListItem.test.tsxApp Sidebar Three Active Sub-AgentsandBestOfSubagentsRisks
Low-to-medium risk in left-sidebar row layout and grouped sub-agent rendering. The main mitigation is that the connector now derives from shared layout primitives, and the new tests cover both the geometry helpers and rendered connector positions.
Generated with
mux• Model:openai:gpt-5.4• Thinking:xhigh• Cost:$6.76