🤖 perf: speed up immersive review for large diffs#3175
Merged
Conversation
Memoize immersive review progress and active-file comment index calculations so cursor movement in large diff-heavy files does not repeatedly rescan every hunk or rebuild minimap line maps. --- _Generated with `mux` • Model: `openai:gpt-5.4` • Thinking: `xhigh` • Cost: `$2.23`_ <!-- mux-attribution: model=openai:gpt-5.4 thinking=xhigh costs=2.23 -->
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Member
|
Manually verified this works well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Immersive Review was doing repeated hot-path work during normal rerenders in large diff-heavy files. This change memoizes review-progress aggregation and active-file comment indicator mapping so keyboard navigation and cursor movement do less work in 3000+ LOC reviews.
Background
A user reported noticeable slowness in Immersive Review for large files with many diffs. The existing render path recalculated changed-line progress across all hunks and rebuilt minimap comment indices from the rendered overlay during routine immersive updates, which made the experience feel heavier than it needed to.
Implementation
allHunkscommentLineIndicesisReadonce so the memo dependencies stay narrow and lint-cleanValidation
make static-checkbun test src/browser/features/RightSidebar/CodeReview/ImmersiveReviewView.test.tsxRisks
Low. The change is scoped to Immersive Review's derived render data and does not alter navigation or review semantics, but stale memo dependencies would show up as incorrect progress or missing comment markers.
Generated with
mux• Model:openai:gpt-5.4• Thinking:xhigh• Cost:$2.23