🤖 fix: restore starlark code block highlighting#3187
Merged
Conversation
Map unsupported Starlark/Bazel fence names to Python so Shiki keeps highlighting those code blocks instead of warning and falling back to plain text. Also reuse the shared language mapping in the highlight worker. --- _Generated with `mux` • Model: `openai:gpt-5.4` • Thinking: `xhigh` • Cost: `$0.00`_ <!-- mux-attribution: model=openai:gpt-5.4 thinking=xhigh costs=0.00 -->
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use a shared Shiki language fallback so Starlark/Bazel fenced code blocks stay highlighted instead of logging an unsupported-language warning and falling back to plain text.
Background
Closes #3117. The shipped Shiki bundle does not include a native
starlarkgrammar, so attempting to highlight those fences throws at runtime.Implementation
starlark,bazel, andbzlto Python in the shared Shiki language mapperValidation
bun test src/browser/utils/highlighting/shiki-shared.test.tsmake typecheckmake lintmake static-checkRisks
Low. This only changes how unsupported Bazel/Starlark fences are mapped for syntax highlighting, and it keeps the existing plain-text fallback if highlighting still fails for another reason.
Generated with
mux• Model:openai:gpt-5.4• Thinking:xhigh• Cost:$0.00