🤖 fix: preserve JSX-like tags in markdown#3256
Merged
Merged
Conversation
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Keep pasted component names visible in chat history by treating unknown raw HTML as literal text before rehype parses and sanitizes markdown content. Supported sanitized HTML, such as details/summary blocks, still renders normally.
---
_Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `2393140{MUX_COSTS_USD:-0.00}`_
<!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=0.00 -->
Co-authored-by: Mux <noreply@coder.com>
coadler
force-pushed
the
fix-preserve-jsx-markdown-tags
branch
from
2417c04 to
39efa44
Compare
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
mux-bot Bot
added a commit
that referenced
this pull request
May 11, 2026
sanitizeSchema.tagNames is built locally with a concrete array literal —
`{ ...defaultSchema, tagNames: [...] }` — so after the spread it is always
defined. The `?? []` fallback that landed alongside the JSX-tag preservation
plugin (#3256) is dead defensive code: the inner spread `...(defaultSchema.tagNames ?? [])`
still guards the library type, but the outer `(sanitizeSchema.tagNames ?? [])`
on the `ALLOWED_RAW_HTML_TAG_NAMES` Set construction can never be undefined.
Drop the fallback and add a comment explaining the invariant so a future
refactor doesn't reintroduce it. Pure refactor — emitted JS, the
`rehypePreserveUnknownRawHtml` plugin, the unknown-tag preservation behavior
added in #3256, and the existing `MarkdownRenderer.raw-html` test suite are
all unchanged.
Co-authored-by: Mux <noreply@coder.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves JSX-like component names in chat markdown so pasted errors like
<SignOutButton/>remain visible in message history instead of being parsed as unknown HTML and stripped by sanitization.Background
Markdown rendering intentionally supports sanitized raw HTML for cases like collapsible
<details>blocks. That same raw HTML path caused copied React/JSX component names in error text to be parsed as HTML elements and removed byrehype-sanitize.Implementation
Adds a pre-
rehypeRawplugin that converts raw HTML containing tags outside the sanitize allowlist into text. Allowed sanitized HTML still flows throughrehypeRaw,rehype-sanitize, andrehype-hardenunchanged.Validation
bun test src/browser/features/Messages/MarkdownRenderer.raw-html.test.tsxbun test src/browser/features/Messages/InlineSkillMarkdown.test.tsx src/browser/features/Messages/TypewriterMarkdown.test.tsx src/browser/features/Messages/MarkdownComponents.test.tsxbun x eslint --max-warnings 0 src/browser/features/Messages/MarkdownCore.tsx src/browser/features/Messages/MarkdownRenderer.raw-html.test.tsxbun x prettier --check src/browser/features/Messages/MarkdownCore.tsx src/browser/features/Messages/MarkdownRenderer.raw-html.test.tsxnix shell nixpkgs#shfmt nixpkgs#hadolint -c make static-checkRisks
Low. The change is limited to raw HTML markdown nodes before sanitization. Unknown tags become escaped text, while supported sanitized HTML remains available.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:2394133{MUX_COSTS_USD:-0.00}