🤖 fix: disable ask_user_question in mux run#3336
Merged
Merged
Conversation
Member
Author
|
/coder-agents-review |
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ibetitsmike
approved these changes
May 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
mux-bot Bot
added a commit
that referenced
this pull request
May 20, 2026
Five toolPolicy entries differed only by tool name and all shared
`action: "disable" as const`. Hoist the names into a local
`CLI_DISABLED_TOOL_NAMES` tuple and produce the policy array via
`.map(name => ({ regex_match: name, action: "disable" as const }))`.
Picked from the `ask_user_question` disable that landed in #3336 —
that commit added a fifth identical-shape entry, so the table form is
now strictly tidier than five copy-pasted object literals. Adding the
next disabled CLI tool drops to one string instead of duplicating the
shape. Byte-equivalent toolPolicy contents (same five entries, same
order, same action), so no behavior change.
Generated with `mux`
mux-bot Bot
added a commit
that referenced
this pull request
May 20, 2026
Five toolPolicy entries differed only by tool name and all shared
`action: "disable" as const`. Hoist the names into a local
`CLI_DISABLED_TOOL_NAMES` tuple and produce the policy array via
`.map(name => ({ regex_match: name, action: "disable" as const }))`.
Picked from the `ask_user_question` disable that landed in #3336 —
that commit added a fifth identical-shape entry, so the table form is
now strictly tidier than five copy-pasted object literals. Adding the
next disabled CLI tool drops to one string instead of duplicating the
shape. Byte-equivalent toolPolicy contents (same five entries, same
order, same action), so no behavior change.
Generated with `mux`
mux-bot Bot
added a commit
that referenced
this pull request
May 21, 2026
Five toolPolicy entries differed only by tool name and all shared
`action: "disable" as const`. Hoist the names into a local
`CLI_DISABLED_TOOL_NAMES` tuple and produce the policy array via
`.map(name => ({ regex_match: name, action: "disable" as const }))`.
Picked from the `ask_user_question` disable that landed in #3336 —
that commit added a fifth identical-shape entry, so the table form is
now strictly tidier than five copy-pasted object literals. Adding the
next disabled CLI tool drops to one string instead of duplicating the
shape. Byte-equivalent toolPolicy contents (same five entries, same
order, same action), so no behavior change.
Generated with `mux`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable
ask_user_questionfor headlessmux runsessions so CLI runs cannot stall waiting for a desktop/mobile answer UI.Background
mux runalready disables UI-only tools such as TODO/status/notify.ask_user_questionis also UI-dependent unless prefilled answers are supplied, so exposing it in headless CLI runs can leave the session waiting for an answer path the CLI does not provide.Implementation
Adds
ask_user_questionto the CLItoolPolicydisable list used bymux run, with an inline comment explaining the headless interaction constraint.Validation
bun run typecheckbun test src/cli/run.test.tsmake fmt-checkmake lintmake static-checkRisks
Low. This only narrows the tool set for
mux run; desktop/mobile and normal plan-mode UI flows are unchanged.Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$9.14