🤖 feat: add intent-only bash summaries#3360
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65e3d7bebf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ThomasK33
force-pushed
the
feat/bash-intent-only-summaries
branch
from
65e3d7b to
ecca4c3
Compare
|
@codex review |
1 similar comment
|
@codex review |
ThomasK33
force-pushed
the
feat/bash-intent-only-summaries
branch
from
ecca4c3 to
2634855
Compare
|
Addressed Codex feedback:
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ThomasK33
force-pushed
the
feat/bash-intent-only-summaries
branch
from
2634855 to
23afb69
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 23afb6988e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ThomasK33
force-pushed
the
feat/bash-intent-only-summaries
branch
from
23afb69 to
de88aaa
Compare
|
Addressed Codex feedback:
|
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
# Conflicts: # src/browser/stores/WorkspaceStore.test.ts
ThomasK33
force-pushed
the
feat/bash-intent-only-summaries
branch
from
de88aaa to
eea511d
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The intent-only summary mode added in #3360 introduced a second normalizeForComparison(value) !== normalizeForComparison(command) call, so the same whitespace- and case-insensitive command-equality check now appears in three spots: filtering a redundant intent, filtering a redundant display-name fallback, and the trailing-using-clause stripper. Pull that predicate into a single matchesCommand helper next to normalizeForComparison so all three callsites read as 'intent (or display name, or candidate) is the same as the command' and any future tweak to the comparison normalization happens in one place. Pure rename/extract: the helper composes the existing normalizer, returns the identical boolean, and no callsite changes its branch direction.
1 participant
Summary
Adds an intent-only option for collapsed bash summaries, alongside the existing command and intent-plus-command modes.
Background
The settings UI already allowed users to choose between seeing the raw bash command or the model intent plus command. This adds the missing mode for users who only want the model intent in collapsed bash rows.
Implementation
Validation
bun test src/browser/features/Tools/bashCollapsedSummary.test.ts src/browser/features/Settings/Sections/GeneralSection.test.tsxbun test src/browser/stores/WorkspaceStore.test.ts src/browser/stores/GitStatusStore.test.ts src/browser/utils/commands/sources.test.ts src/browser/utils/chatCommands.test.ts src/browser/features/Messages/UserMessageContent.inline-skill.test.tsx src/node/services/tools/task_apply_git_patch.test.tsmake typecheckmake lintmake fmt-checkmake static-checkRisks
Low: change is scoped to bash tool collapsed summary presentation and a global UI preference; the command remains visible in expanded details.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$22.14