Skip to content

🤖 feat: single-line immersive review TODO bar#3444

Merged
ammario merged 1 commit into
mainfrom
immersive-review-cstt
Jun 3, 2026
Merged

🤖 feat: single-line immersive review TODO bar#3444
ammario merged 1 commit into
mainfrom
immersive-review-cstt

Conversation

@ammar-agent
Copy link
Copy Markdown
Collaborator

Summary

Collapse the immersive-review agent TODO bar from two stacked rows into a single line. The "TODO" label, the agent's plan (rendered as the existing horizontally-scrolling strip), and the live streaming/question chip now all share one row, and the bar is no longer collapsible.

Background

The TODO bar at the top of immersive review previously rendered two rows: a header button (TODO · summary + expand chevron + streaming chip) above a separate full-width plan strip that appeared when expanded. That reserved more vertical space than necessary in the review viewport. The ask was to make it one line; per follow-up, the collapse affordance isn't needed either.

Implementation

  • ImmersiveReviewAgentStatusBar.tsx: replaced the toggle button + conditional strip with a single min-h-7 flex row — a static List + "TODO" label, the TodoList (layout="horizontal") strip in a min-w-0 flex-1 container so it scrolls sideways and stays bounded, and the streaming chip pinned right via the existing renderStatusChip. Removed the persisted expanded state, the now-redundant count-summary computation, and the unused ChevronDown/ChevronRight/usePersistedState imports. Used min-h-7 rather than a fixed h-7 so the row grows to the strip's natural height instead of clipping the chips.
  • storage.ts: removed getImmersiveReviewAgentBarExpandedKey (its only consumer) and its entry in the ephemeral-key cleanup list.
  • Tests/stories: updated the unit test to assert the single-line plan renders with no collapse button, dropped the collapse/persistence test, and refreshed story comments. The streaming-only (no-plan) path is unchanged.

Risks

Low. Scoped to the immersive-review status bar's presentation; no change to streaming/question state wiring or the leaf-subscription re-render isolation. Removing the persisted-expand key is safe — it was a transient, not-copied-on-fork UI preference, and stale localStorage entries are simply ignored.


Generated with mux • Model: anthropic:claude-opus-4-8 • Thinking: xhigh • Cost: $1.92

@ammar-agent
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ammario ammario merged commit edd902c into main Jun 3, 2026
22 checks passed
@ammario ammario deleted the immersive-review-cstt branch June 3, 2026 17:32
@mux-bot mux-bot Bot mentioned this pull request Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants