🤖 feat: single-line immersive review TODO bar#3444
Merged
Conversation
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Collapse the immersive-review agent TODO bar from two stacked rows into a single line. The "TODO" label, the agent's plan (rendered as the existing horizontally-scrolling strip), and the live streaming/question chip now all share one row, and the bar is no longer collapsible.
Background
The TODO bar at the top of immersive review previously rendered two rows: a header button (
TODO · summary+ expand chevron + streaming chip) above a separate full-width plan strip that appeared when expanded. That reserved more vertical space than necessary in the review viewport. The ask was to make it one line; per follow-up, the collapse affordance isn't needed either.Implementation
ImmersiveReviewAgentStatusBar.tsx: replaced the toggle button + conditional strip with a singlemin-h-7flex row — a staticList+ "TODO" label, theTodoList(layout="horizontal") strip in amin-w-0 flex-1container so it scrolls sideways and stays bounded, and the streaming chip pinned right via the existingrenderStatusChip. Removed the persistedexpandedstate, the now-redundant count-summary computation, and the unusedChevronDown/ChevronRight/usePersistedStateimports. Usedmin-h-7rather than a fixedh-7so the row grows to the strip's natural height instead of clipping the chips.storage.ts: removedgetImmersiveReviewAgentBarExpandedKey(its only consumer) and its entry in the ephemeral-key cleanup list.Risks
Low. Scoped to the immersive-review status bar's presentation; no change to streaming/question state wiring or the leaf-subscription re-render isolation. Removing the persisted-expand key is safe — it was a transient, not-copied-on-fork UI preference, and stale localStorage entries are simply ignored.
Generated with
mux• Model:anthropic:claude-opus-4-8• Thinking:xhigh• Cost:$1.92