🤖 fix: prevent discarded workflow runs from reappearing#3449
Merged
Conversation
Only refresh workflow run cards that are already anchored in the current transcript. Durable workflow run records can outlive the chat rows that launched them after message edits truncate history, so unanchored runs must not be projected back into the chat. Validation: - bun test src/browser/utils/workflowRunMessages.test.ts - make typecheck - make lint --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `$8.21`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=8.21 -->
Address deep-review feedback on discarded slash workflow runs: - delay workflow run projection until the transcript catch-up marker has hydrated current history - treat durable workflow card metadata as a repairable card anchor - treat surviving workflow trigger rows as anchors for repairing a missing card while still suppressing fully unanchored durable runs Validation: - bun test src/browser/utils/workflowRunMessages.test.ts - bun test src/browser/utils/workflowRunMessages.test.ts src/browser/components/PinnedTodoList/PinnedTodoList.test.tsx src/browser/features/RightSidebar/CodeReview/ImmersiveReviewAgentStatusBar.test.tsx src/browser/utils/commands/sources.test.ts - make typecheck - make lint - git diff --check --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `$60.66`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=60.66 -->
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes workflow run card projection so durable workflow records no longer reappear in chat after their transcript rows were intentionally discarded, while still allowing anchored workflow cards to refresh or repair.
Background
A slash-invoked workflow can outlive the chat rows that launched it. After an edit or compaction removes those display-only rows from the active transcript,
listRuns()can still return the completed durable run. The UI previously projected that unanchored run back into chat, causing old completed workflows to appear at the bottom unexpectedly.Implementation
Validation
bun test src/browser/utils/workflowRunMessages.test.tsbun test src/browser/utils/workflowRunMessages.test.ts src/browser/components/PinnedTodoList/PinnedTodoList.test.tsx src/browser/features/RightSidebar/CodeReview/ImmersiveReviewAgentStatusBar.test.tsx src/browser/utils/commands/sources.test.tsmake typecheckmake lintgit diff --checkmake static-checkRisks
Medium. The touched path is transcript projection/hydration for workflow cards. The change intentionally narrows unanchored projections, while preserving refresh for cards and triggers that are still present in the active transcript.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$71.87