🤖 fix: render foreground workflows like backgrounded runs#3457
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78190c6323
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ThomasK33
force-pushed
the
workflow-ui-mbx0
branch
from
78190c6 to
2f5774c
Compare
|
Addressed Codex P2: uniquely discovered foreground runs are now treated as confirmed identities for actions while the foreground tool call is still executing. Ambiguous matches continue to hide actions. Added regression coverage for discovered foreground interrupt and ambiguous-match action hiding. Validation after the fix:
@codex review |
Discover the durable foreground workflow run while the tool is still executing, then render and refresh the same live run details used by backgrounded workflow runs. Add Storybook comparison stories and regression coverage for the executing status and live foreground run discovery. --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `5.99`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=15.99 -->
ThomasK33
force-pushed
the
workflow-ui-mbx0
branch
from
2f5774c to
716e1ad
Compare
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
1 participant
Summary
Render foreground workflow runs with the same live workflow details as backgrounded runs while they are still executing.
Background
Foreground workflow tool calls block until completion, so the initial tool message does not include a durable
runId. That left the UI showing only the raw arguments panel during execution. This change lets the card safely discover the matching active workflow run and render definition/details/events while the foreground tool is still running.Implementation
updatedAt, with event sequence as the same-millisecond tie-breaker.Validation
make static-checkbun test src/browser/features/Tools/WorkflowRunToolCall.test.tsxbun run prettier --check src/browser/features/Tools/WorkflowRunToolCall.tsx src/browser/features/Tools/WorkflowRunToolCall.test.tsx src/browser/features/Tools/WorkflowRunToolCall.stories.tsxbun x eslint src/browser/features/Tools/WorkflowRunToolCall.tsx src/browser/features/Tools/WorkflowRunToolCall.test.tsx src/browser/features/Tools/WorkflowRunToolCall.stories.tsxmake typecheckagent-browser: discovered foreground run rendering, interrupt transition, and resume transition. Screenshots/video were captured locally for review evidence.Risks
Moderate UI-state risk around workflow cards only. The discovery path is intentionally conservative: it declines ambiguous matches, filters stale runs, and only enables mutations for confirmed run IDs.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$109.15