Skip to content

🤖 fix: isolate workflow action exec diagnostics#3469

Merged
ThomasK33 merged 2 commits into
mainfrom
workflows-qr34
Jun 5, 2026
Merged

🤖 fix: isolate workflow action exec diagnostics#3469
ThomasK33 merged 2 commits into
mainfrom
workflows-qr34

Conversation

@ThomasK33
Copy link
Copy Markdown
Member

Summary

Fix workflow action diagnostics so output produced by ctx.exec commands stays on the returned command result instead of being echoed into the action-level stdout/stderr fields. Also suppress stderr from the internal ps cleanup probe so host warnings do not pollute action diagnostics.

Background

A workflow run showed built-in Git actions with confusing action diagnostics: stdout contained concatenated internal Git command output and stderr contained host ps warnings such as bad data in /proc/uptime. The structured output fields were usable, but the action-level diagnostics were misleading.

Implementation

  • Stop forwarding ctx.exec child stdout/stderr chunks to the action child process stdout/stderr while still draining and returning those streams from ctx.exec.
  • Run the cleanup ps probe with stderr ignored.
  • Add regression coverage for command-output isolation and deterministic fake-ps cleanup warning suppression.
  • Keep the Git action workflow regression assertions that distinguish git.diff patch output from git.diffStat stat output.

Deep Review

Ran deep-review-workflow after the initial commit. It identified two actionable findings, both addressed:

  • Added deterministic coverage for noisy cleanup ps stderr.
  • Removed the accidental duplicate scratch workflow .gitignore block.

Workflow run: wfr_4254a7721b3f70f4.

Validation

  • bun test src/node/services/workflows/WorkflowActionRunner.test.ts --timeout 30000 --test-name-pattern "cleanup ps warnings|ctx.exec output"
  • bun test src/node/services/workflows/WorkflowRunner.test.ts --timeout 30000 --test-name-pattern "runs built-in Git workflow actions"
  • Isolated git check-ignore -v --no-index check for .mux/workflows/.scratch/.gitignore vs a scratch draft file
  • git diff --check origin/main..HEAD && git diff --check
  • make static-check

Risks

Low-to-medium. The production change affects workflow action diagnostics only: command streams are still drained to avoid backpressure and still returned through ctx.exec. Users who depended on implicit live echoing from ctx.exec into action stdout/stderr would no longer see those chunks there; actions can still log explicitly with console.log when desired.


Generated with mux • Model: openai:gpt-5.5 • Thinking: xhigh • Cost: 702472{MUX_COSTS_USD:-0}

ThomasK33 added 2 commits June 5, 2026 18:10
Prevent ctx.exec command output and descendant-cleanup warnings from polluting workflow action stdout/stderr while keeping command output available on ctx.exec results.

---

_Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `614410{MUX_COSTS_USD:-0}`_

<!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=7.31 -->
Add deterministic coverage for noisy ps cleanup and remove the accidental duplicate scratch workflow ignore rule found by deep review.

---

_Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `699312{MUX_COSTS_USD:-0}`_

<!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=7.31 -->
@ThomasK33
Copy link
Copy Markdown
Member Author

@codex review

Please review the workflow action diagnostics fix.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ThomasK33 ThomasK33 added this pull request to the merge queue Jun 5, 2026
Merged via the queue into main with commit 4c4b87d Jun 5, 2026
40 of 42 checks passed
@ThomasK33 ThomasK33 deleted the workflows-qr34 branch June 5, 2026 19:08
@mux-bot mux-bot Bot mentioned this pull request Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant