🤖 fix: improve heartbeat modal layout#3612
Merged
Merged
Conversation
Make the workspace heartbeat settings dialog wider on desktop, split the message editor into a larger column, and add Storybook coverage for desktop/mobile long-message layouts.
---
_Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `1250988{MUX_COSTS_USD:-unknown}`_
<!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=12.69 -->
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the workspace heartbeat configuration modal so long custom messages are easier to read and edit. The dialog now expands wider on desktop, uses a two-column layout when heartbeats are enabled, keeps actions pinned in a footer, and adds desktop/mobile Storybook scenarios for the long-message layout.
Background
The previous modal constrained the heartbeat message to a narrow field, making recurring background prompts hard to review before saving.
Implementation
Validation
make static-checkbun test src/browser/components/WorkspaceHeartbeatModal/WorkspaceHeartbeatModal.test.tsxmake typecheckMUX_ESLINT_CONCURRENCY=1 make lintmake fmt-checkagent-browserat 1280×800 and 375×667, capturing screenshots and a WebM recording.Risks
Low. This is scoped to the heartbeat settings modal presentation and Storybook coverage; existing save/load behavior is covered by the focused modal tests.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$12.69