Fix integration test coverage upload to Codecov #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration-tests flag was incorrectly configured to look for coverage in tests/** paths, but Jest collects coverage from src/** files (as specified in jest.config.js). This caused integration test coverage to not be properly tracked by Codecov. Updated integration-tests flag to cover src/** paths, matching the actual coverage data generated by Jest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The integration-tests flag in
codecov.ymlwas incorrectly configured to look for coverage intests/**paths, but Jest collects coverage fromsrc/**files (as specified injest.config.js). This caused integration test coverage to not be properly tracked by Codecov.Root Cause
collectCoverageFromconfig specifiessrc/**tests/**exercise application code insrc/****/*.test.ts) are explicitly ignored in codecov configintegration-testsflagSolution
Updated the
integration-testsflag to coversrc/**paths, matching the actual coverage data generated by Jest.Both unit tests and integration tests now correctly point to
src/**since both generate coverage for source code, just through different test suites.Testing
This PR will verify that integration test coverage is properly uploaded to Codecov when CI runs.