-
Notifications
You must be signed in to change notification settings - Fork 29
🤖 Add SSH runtime badge to workspace UI #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a visual indicator showing which SSH host a workspace is running on: - Badge displays 🖥️ icon + hostname for SSH workspaces - Appears in workspace sidebar (left of workspace name) and title bar - Tooltip shows full SSH host string on hover - No badge shown for local workspaces Implementation: - New RuntimeBadge component with accent-colored styling - extractSshHostname() utility handles various SSH host formats - Uses existing runtimeConfig from WorkspaceMetadata (no new IPC) - Comprehensive test coverage for hostname extraction Generated with `cmux`
Move RuntimeBadge into same grid cell as workspace name to avoid breaking the existing layout. Badge and name now share a flex container. Generated with `cmux`
Add justify-end to flex container to restore right-alignment of workspace name like it was before the badge was added. Generated with `cmux`
Replace 🖥️ emoji with a clean SVG server rack icon that matches the app's visual style. Icon uses currentColor to inherit the accent color from the badge. Generated with `cmux`
Display SSH runtime badge in the AIView workspace header alongside the status indicator and git status. Badge appears between git status and the project/branch name. Changes: - Add runtimeConfig prop to AIViewProps - Pass runtimeConfig from App.tsx using workspaceMetadata - Render RuntimeBadge in workspace title header Generated with `cmux`
Remove RuntimeBadge from TitleBar component. Badge should only appear in: 1. Workspace list items (sidebar) 2. Workspace title header (main chat area) The left sidebar title bar should remain minimal with just version info. Generated with `cmux`
|
The integration test failure in This PR only adds UI components for displaying SSH runtime badges and doesn't touch the bash execution code. The test All other checks pass: |
Add workspaces with SSH runtime config to App stories so the runtime badge is visible in Storybook: - SingleProject: feature/auth workspace on dev-server.example.com - MultipleProjects: api-v2 on prod-server.example.com, db-migration on staging.example.com This allows visual testing and demonstration of the runtime badge UI. Generated with `cmux`
**Changes:** - Remove hostname text from badge (icon-only) - Reduce horizontal padding from `px-1.5` to `px-1` - Simplify tooltip to "SSH: hostname" - Hostname still visible on hover **Benefits:** - Saves horizontal space in workspace lists - Less visual clutter - Maintains full functionality via tooltip **Before:** `[icon] hostname` with `px-1.5` **After:** `[icon]` with `px-1` and tooltip --- **Review Note:** This PR is based on the `rt-badge` branch and will have merge conflicts until #427 is merged. Once #427 is merged to main, rebase this PR onto main and the conflicts will be resolved. _Generated with `cmux`_
Visual indicator showing which SSH host a workspace is running on.
Badge displays:
Appears in:
Implementation:
RuntimeBadgecomponent with SVG iconextractSshHostname()utility handles various SSH host formats (hostname, user@host, host:port)runtimeConfigfromWorkspaceMetadata(no new IPC)Generated with
cmux