🤖 Remove sync fs operations and path-finding from runtime #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace all sync fs operations (existsSync, mkdirSync) with async equivalents - Remove executablePaths.ts module entirely - Rely on system PATH for bash and nice executables - Simplifies codebase by 74 lines This ensures the runtime never blocks the main thread during file I/O.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Collaborator
Author
|
All CI tests pass including integration and E2E tests, confirming that relying on system PATH works correctly in our actual runtime environments (CI, Electron, etc.). The path-finding code was unnecessary complexity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates blocking filesystem operations in the runtime layer and removes unnecessary path-finding complexity.
Changes
Removed sync fs operations:
fs.existsSync()+fs.mkdirSync()withfsPromises.access()+fsPromises.mkdir()inLocalRuntime.tsRemoved path-finding module:
executablePaths.ts(57 lines) that was checking hardcoded paths forbashandniceLocalRuntime.tsandSSHRuntime.tsto rely on system PATHVerification
Generated with
cmux