🤖 fix: interrupt stream with pending bash tool near-instantly #478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
InterruptStream(Ctrl+C) was called during a pending bash tool execution, the stream would hang indefinitely. This was especially problematic for SSH workspaces where long-running commands could block the UI for minutes.Root Cause
The AI SDK's
for awaitloop blocks waiting for the current async iterator operation to complete. When a bash tool is executing, the iterator doesn't yield untiltool.execute()returns.Even though we call
abortController.abort(), the bash tool's abort listener was effectively empty:This caused:
cancelStreamSafely()callsabortController.abort()await streamInfo.processingPromisehangs indefinitelyFor SSH workspaces, the SSH runtime's abort handler only kills the local SSH client - the remote command keeps running, making this worse.
Solution
Make the bash tool actively resolve its promise when aborted instead of passively waiting:
This unblocks the chain:
processingPromiseresolvesTesting
Added integration test that verifies interrupt completes in < 2 seconds even when a
sleep 60command is running:Generated with
cmux