🤖 Debug and fix cmux.io deployment #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammario
force-pushed
the
fix-cmux-io-deployment
branch
from
679efee to
fa860c4
Compare
- Add verification logging for CNAME file copy - Update wait_pr_checks.sh to handle merged PRs - Helps diagnose why cmux.io isn't resolving _Generated with `cmux`_
ammario
force-pushed
the
fix-cmux-io-deployment
branch
from
fa860c4 to
0997b59
Compare
FOUND THE BUG! mdbook outputs to docs/book/html/ but we were uploading docs/book/. This is why cmux.io returns 404 - no index.html in the artifact root!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
cmux.io still returns 404 even after PR #49 which added CNAME file.
Root Cause Investigation
Need to verify:
Changes
Next Steps
Once this PR runs, we can see in the logs whether CNAME is correctly placed in the artifact. If it is, the issue may be:
Testing
Check the workflow logs after this runs to verify CNAME is in
docs/book/CNAME.Generated with
cmux