🤖 fix: prevent new workspace modal from closing on outside click #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modal was closing when clicking anywhere on the overlay (dark background). This was not the expected behavior - users should only be able to close the modal via: - Clicking the Cancel button - Clicking Create Workspace after creation - Pressing Escape key Removed onClick handler from ModalOverlay and stopPropagation from ModalContent to prevent accidental modal dismissal. Generated with `cmux`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the new workspace modal behavior so it only closes via explicit user actions (Cancel button, Create Workspace button, or Escape key), not by clicking outside the modal.
Problem
Previously, clicking anywhere on the overlay (dark background) would close the modal, which could lead to accidental dismissal when users are filling out the form.
Solution
Removed:
onClick={handleCancel}fromModalOverlayonClick={(e) => e.stopPropagation()}fromModalContentThe modal now only closes through:
Testing
Manual testing needed:
Generated with
cmux