🤖 ci: reorganize integration tests #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ammar-agent
force-pushed
the
optimize-integration-tests
branch
3 times, most recently
from
e3c4ff2 to
0fdf64e
Compare
- Split sendMessage.test.ts into 5 smaller files to improve parallelism and prevent timeouts - Optimize setupWorkspace to support shared git repo reuse across tests - Optimize buildLargeHistory to write directly to disk instead of using HistoryService loop - Fix flexible image description matching in image tests
- Update setupWorkspaceWithoutProvider to support existing repo reuse - Add withSharedWorkspaceNoProvider helper - Update basic and context tests to use shared repo helpers - Remove duplicate metadata test in context suite - Cleanup unused imports in all suites
ammar-agent
force-pushed
the
optimize-integration-tests
branch
from
0fdf64e to
9739068
Compare
ammar-agent
changed the title
ammario
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated with
muxRefactors the
sendMessageintegration test suite for better organization, maintainability, and performance.Changes
Test Organization
Split monolithic
sendMessage.test.ts(1628 lines) into 5 thematic files:sendMessage.basic.test.ts— core send/receive, interrupt, reconnectionsendMessage.context.test.ts— editing, history truncation, multi-turn conversationssendMessage.errors.test.ts— validation, API key errors, model not foundsendMessage.heavy.test.ts— context limit / auto-truncationsendMessage.images.test.ts— vision model testsShared Workspace Helper
Added
sendMessageTestHelpers.tswith:withSharedWorkspace(provider, testFn)— creates one git repo per test file instead of per-testwithSharedWorkspaceNoProvider(testFn)— for tests that verify behavior without provider configSetup Improvements
setupWorkspaceandsetupWorkspaceWithoutProvidernow accept optionalexistingRepoPathfor repo reusebuildLargeHistorywrites directly tochat.jsonlinstead of sequential appends (30s → <1s)Results