🤖 fix: resolve flaky integration tests in bash runtime and stream resumption #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umption Generated with mux Fixes two independent flakes: 1. tests/ipcMain/runtimeExecuteBash.test.ts: - Relaxed assertion on AI response text which is non-deterministic. - Added strict assertion on tool output to verify command execution success (the actual goal of the test). 2. tests/ipcMain/resumeStream.test.ts: - Replaced magic sleep(100) with proper event synchronization. - Now waits for 'caught-up' event before triggering resume, ensuring the event collector is ready.
Generated with mux tests/ipcMain/createWorkspace.test.ts: Use example.com URL instead of github.com to avoid interference from global git url.insteadOf configuration (which rewrites https://github.com/ to git@github.com:).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated with
muxFixes two independent flakes:
1.
tests/ipcMain/runtimeExecuteBash.test.tsIssue: The test was flaky because it expected the AI model to explicitly describe the output in its text response, which is non-deterministic.
Fix: Prioritized verifying the actual tool output (which is deterministic and proves the runtime works) and made the text response check optional.
2.
tests/ipcMain/resumeStream.test.tsIssue: The test relied on a
setTimeout(100)to wait for IPC subscription, which caused race conditions in CI/loaded environments.Fix: Replaced the sleep with
collector.waitForEvent('caught-up'), which is the correct synchronization signal from the backend.