🤖 fix: add module preloading to fix flaky stream error tests #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both streamErrorRecovery.test.ts and sendMessage.errors.test.ts were failing intermittently with sendMessageWithModel returning success=false. Root cause: concurrent tests were racing on dynamic module imports (tokenizer, AI SDK providers) which could cause intermittent failures when modules weren't fully loaded before test execution. Fix: Add preloadTestModules() call to beforeAll hooks inside the describeIntegration blocks, ensuring modules are loaded before any concurrent tests start. Also moved beforeAll/afterAll hooks inside the describeIntegration blocks so they only run when integration tests are enabled.
ammar-agent
force-pushed
the
fix-stream-error-test-flakes
branch
from
514e0e9 to
bf3cabe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated with
muxFixes intermittent failures in:
tests/ipcMain/streamErrorRecovery.test.tstests/ipcMain/sendMessage.errors.test.tsRoot cause: Concurrent tests were racing on dynamic module imports (tokenizer, AI SDK providers) which could cause intermittent failures when modules weren't fully loaded before test execution.
Fix: Add
preloadTestModules()call tobeforeAllhooks inside thedescribeIntegrationblocks, ensuring modules are loaded before any concurrent tests start.Also moved
beforeAll/afterAllhooks inside thedescribeIntegrationblocks so they only run when integration tests are enabled.