🤖 fix: restore auto-compaction trigger deleted by ORPC migration #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ORPC migration PR (#763) inadvertently deleted the auto-compaction trigger logic when sending messages. This restores: - Check if usage >= threshold before sending regular messages - Execute compaction with continueMessage instead of direct send - Show 'Context threshold reached - auto-compacting...' toast - Proper error handling with input/image restoration The supporting infrastructure (checkAutoCompaction, CompactionWarning, settings UI) remained intact - only the trigger logic was missing. _Generated with `mux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The ORPC migration PR (#763) inadvertently deleted the auto-compaction trigger logic from
ChatInput/index.tsx. This PR restores it.What was deleted
When sending a message, the system should check if context usage has reached the threshold and automatically trigger compaction instead of sending the message directly. This logic was removed during the ORPC refactor.
What this PR restores
usagePercentage >= thresholdPercentagebefore regular message sendsexecuteCompaction()with the message ascontinueMessageWhat still worked (not deleted)
checkAutoCompaction()functionCompactionWarningUI bannerautoCompactionCheckprop was still passed from AIView → ChatInputTesting
make typecheckpassesmake lintpassesGenerated with
mux