🤖 revert: ORPC migration and related commits #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts: - 470e4eb perf: fix streaming content delay from ORPC schema validation (#774) - b437977 feat: add backend support for soft-interrupts (#767) - df30cbc fix: use ResultSchema for sendMessage output to prevent field stripping (#773) - 41c77ef fix: testUtils formatting (#771) - 3ee7288 refactor: migrate IPC layer to ORPC for type-safe RPC (#763)
deansheather
approved these changes
Nov 28, 2025
ThomasK33
added a commit
that referenced
this pull request
Nov 29, 2025
This commit reintroduces the ORPC refactoring that was originally merged in #763 and subsequently reverted in #777 due to regressions. ## Original PR: #763 Replaces the custom IPC layer with oRPC for type-safe RPC between browser/renderer and backend processes. ## Why it was reverted (#777) The original migration caused regressions including: - Streaming content delay from ORPC schema validation - Field stripping issues in sendMessage output - Auto-compaction trigger deletion ## What's different this time - Rebased onto latest main which includes fixes that were developed post-revert (model favorites, auto-compaction, etc.) - Conflict resolution preserves upstream features added after revert: - Workspace name collision retry with hash suffix - Mux Gateway coupon code handling with default models - AWS Bedrock credential nested structure ## Key Changes ### Architecture - New ORPC router (src/node/orpc/router.ts) - Central router with Zod schemas - Schema definitions (src/common/orpc/schemas.ts) - Shared validation - ServiceContainer (src/node/services/serviceContainer.ts) - DI container - React integration (src/browser/orpc/react.tsx) - ORPCProvider and useORPC() ### Transport - Desktop (Electron): MessagePort-based RPC via @orpc/server/message-port - Server mode: HTTP + WebSocket via @orpc/server/node and @orpc/server/ws - Auth middleware with timing-safe token comparison ### Removed - src/browser/api.ts (old HTTP/WS client) - src/node/services/ipcMain.ts (old IPC handler registration) - Old IPC method definitions in preload.ts --- _Generated with mux_
6 tasks
ThomasK33
added a commit
that referenced
this pull request
Nov 29, 2025
This commit reintroduces the ORPC refactoring that was originally merged in #763 and subsequently reverted in #777 due to regressions. ## Original PR: #763 Replaces the custom IPC layer with oRPC for type-safe RPC between browser/renderer and backend processes. ## Why it was reverted (#777) The original migration caused regressions including: - Streaming content delay from ORPC schema validation - Field stripping issues in sendMessage output - Auto-compaction trigger deletion ## What's different this time - Rebased onto latest main which includes fixes that were developed post-revert (model favorites, auto-compaction, etc.) - Conflict resolution preserves upstream features added after revert: - Workspace name collision retry with hash suffix - Mux Gateway coupon code handling with default models - AWS Bedrock credential nested structure ## Key Changes ### Architecture - New ORPC router (src/node/orpc/router.ts) - Central router with Zod schemas - Schema definitions (src/common/orpc/schemas.ts) - Shared validation - ServiceContainer (src/node/services/serviceContainer.ts) - DI container - React integration (src/browser/orpc/react.tsx) - ORPCProvider and useORPC() ### Transport - Desktop (Electron): MessagePort-based RPC via @orpc/server/message-port - Server mode: HTTP + WebSocket via @orpc/server/node and @orpc/server/ws - Auth middleware with timing-safe token comparison ### Removed - src/browser/api.ts (old HTTP/WS client) - src/node/services/ipcMain.ts (old IPC handler registration) - Old IPC method definitions in preload.ts --- _Generated with mux_
ThomasK33
added a commit
that referenced
this pull request
Nov 30, 2025
This commit reintroduces the ORPC refactoring that was originally merged in #763 and subsequently reverted in #777 due to regressions. ## Original PR: #763 Replaces the custom IPC layer with oRPC for type-safe RPC between browser/renderer and backend processes. ## Why it was reverted (#777) The original migration caused regressions including: - Streaming content delay from ORPC schema validation - Field stripping issues in sendMessage output - Auto-compaction trigger deletion ## What's different this time - Rebased onto latest main which includes fixes that were developed post-revert (model favorites, auto-compaction, etc.) - Conflict resolution preserves upstream features added after revert: - Workspace name collision retry with hash suffix - Mux Gateway coupon code handling with default models - AWS Bedrock credential nested structure ## Key Changes ### Architecture - New ORPC router (src/node/orpc/router.ts) - Central router with Zod schemas - Schema definitions (src/common/orpc/schemas.ts) - Shared validation - ServiceContainer (src/node/services/serviceContainer.ts) - DI container - React integration (src/browser/orpc/react.tsx) - ORPCProvider and useORPC() ### Transport - Desktop (Electron): MessagePort-based RPC via @orpc/server/message-port - Server mode: HTTP + WebSocket via @orpc/server/node and @orpc/server/ws - Auth middleware with timing-safe token comparison ### Removed - src/browser/api.ts (old HTTP/WS client) - src/node/services/ipcMain.ts (old IPC handler registration) - Old IPC method definitions in preload.ts --- _Generated with mux_
ThomasK33
added a commit
that referenced
this pull request
Nov 30, 2025
This commit reintroduces the ORPC refactoring that was originally merged in #763 and subsequently reverted in #777 due to regressions. ## Original PR: #763 Replaces the custom IPC layer with oRPC for type-safe RPC between browser/renderer and backend processes. ## Why it was reverted (#777) The original migration caused regressions including: - Streaming content delay from ORPC schema validation - Field stripping issues in sendMessage output - Auto-compaction trigger deletion ## What's different this time - Rebased onto latest main which includes fixes that were developed post-revert (model favorites, auto-compaction, etc.) - Conflict resolution preserves upstream features added after revert: - Workspace name collision retry with hash suffix - Mux Gateway coupon code handling with default models - AWS Bedrock credential nested structure ## Key Changes ### Architecture - New ORPC router (src/node/orpc/router.ts) - Central router with Zod schemas - Schema definitions (src/common/orpc/schemas.ts) - Shared validation - ServiceContainer (src/node/services/serviceContainer.ts) - DI container - React integration (src/browser/orpc/react.tsx) - ORPCProvider and useORPC() ### Transport - Desktop (Electron): MessagePort-based RPC via @orpc/server/message-port - Server mode: HTTP + WebSocket via @orpc/server/node and @orpc/server/ws - Auth middleware with timing-safe token comparison ### Removed - src/browser/api.ts (old HTTP/WS client) - src/node/services/ipcMain.ts (old IPC handler registration) - Old IPC method definitions in preload.ts --- _Generated with mux_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts:
Due to a huge number of regressions.
Generated with
mux