fix: anthropic cache improvements #781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Use getProviderFetch() instead of defaultFetchWithUnlimitedTimeout when wrapping Anthropic fetch to preserve user-configured custom fetch (proxies, etc.) - Handle provider-defined tools (like Anthropic's webSearch) by spreading providerOptions directly instead of recreating with createTool() (provider-defined tools have type: 'provider-defined' and cannot be recreated) - Add test for provider-defined tool handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK's
providerOptions.anthropic.cacheControlisn't translated to rawcache_controlfor tools/content parts. Fixed via HTTP-level fetch wrapper injectingcache_controlon last tool and second-to-last message.Also: extended cache detection to gateway providers (
mux-gateway:anthropic/...), fixed array content handling, tools now recreated viacreateTool()(SDK requires providerOptions at creation).