Skip to content

🤖 Fix: macOS code signing with newline handling #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ammario merged 2 commits into from
Oct 7, 2025
Merged

🤖 Fix: macOS code signing with newline handling #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85db586
Fix: macOS code signing by decoding certificate to file
ammario Oct 7, 2025
84f3775
Fix: Use BSD-compatible base64 flag for macOS
ammario Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,14 @@ jobs:
run: bun run build

- name: Package for macOS
env:
CSC_LINK: ${{ secrets.MACOS_CERTIFICATE && format('base64:{0}', secrets.MACOS_CERTIFICATE) || '' }}
CSC_KEY_PASSWORD: ${{ secrets.MACOS_CERTIFICATE_PWD }}
run: bun run dist:mac
run: |
# Decode certificate to file to avoid issues with newlines in base64 string
if [ -n "${{ secrets.MACOS_CERTIFICATE }}" ]; then
echo "${{ secrets.MACOS_CERTIFICATE }}" | base64 -D > /tmp/certificate.p12
export CSC_LINK="/tmp/certificate.p12"
export CSC_KEY_PASSWORD="${{ secrets.MACOS_CERTIFICATE_PWD }}"
fi
bun run dist:mac

- name: Upload macOS DMG
uses: actions/upload-artifact@v4
Expand Down
Loading