🤖 fix: remove watch depth limit breaking HMR for nested files #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The depth: 3 setting added in #540 for Windows compatibility prevents Vite from detecting changes in directories deeper than 3 levels. Source files go up to 6 levels deep (e.g., src/browser/components/Settings/sections/). This broke HMR for most component files during 'make dev'. The other Windows-specific settings (polling, awaitWriteFinish) remain in place - only the depth restriction is removed. _Generated with `mux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
depth: 3setting added in #540 for Windows compatibility prevents Vite from detecting changes in directories deeper than 3 levels. Source files go up to 6 levels deep (e.g.,src/browser/components/Settings/sections/).This broke HMR for most component files during
make dev.The other Windows-specific settings (polling, awaitWriteFinish) remain in place - only the depth restriction is removed.
cc @ibetitsmike
Generated with
mux