🤖 fix: buffer terminal output until client subscribes #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In server mode, there was a race condition where the shell prompt would be lost because the PTY started emitting output before the HTTP response (with session ID) returned and before the client registered its WebSocket handler. The fix adds output buffering on the server side: - PTY output is buffered in the session until client subscribes - New TERMINAL_SUBSCRIBE IPC channel to signal readiness - Client calls subscribe after registering its output handler - Server flushes buffered output when subscribe is called This ensures the initial shell prompt is always delivered to the terminal. _Generated with `mux`_
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 1, 2025
In server mode, there was a race condition where the shell prompt would be lost because the PTY started emitting output before the HTTP response (with session ID) returned and before the client registered its WebSocket handler. **The fix adds output buffering on the server side:** - PTY output is buffered in the session until client subscribes - New `TERMINAL_SUBSCRIBE` IPC channel to signal readiness - Client calls subscribe after registering its output handler - Server flushes buffered output when subscribe is called This ensures the initial shell prompt is always delivered to the terminal. _Generated with `mux`_
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 1, 2025
In server mode, there was a race condition where the shell prompt would be lost because the PTY started emitting output before the HTTP response (with session ID) returned and before the client registered its WebSocket handler. **The fix adds output buffering on the server side:** - PTY output is buffered in the session until client subscribes - New `TERMINAL_SUBSCRIBE` IPC channel to signal readiness - Client calls subscribe after registering its output handler - Server flushes buffered output when subscribe is called This ensures the initial shell prompt is always delivered to the terminal. _Generated with `mux`_
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Contributor
Author
|
Closing this PR as the issue has already been fixed on main via the ORPC refactor. The new See Generated with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In server mode, there was a race condition where the shell prompt would be lost because the PTY started emitting output before the HTTP response (with session ID) returned and before the client registered its WebSocket handler.
The fix adds output buffering on the server side:
TERMINAL_SUBSCRIBEIPC channel to signal readinessThis ensures the initial shell prompt is always delivered to the terminal.
Generated with
mux