🤖 fix: add downgrade compatibility for incompatible runtime configs #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
force-pushed
the
downgrade-compatibility-fix
branch
from
b4d4b11 to
442a608
Compare
When users upgrade to a version with new runtime types (like 'local' without srcBaseDir for project-dir mode, or new 'worktree' type) and then downgrade, the old version shows a clear error instead of crashing. Changes: - Add IncompatibleRuntimeError for workspaces from newer mux versions - Add isIncompatibleRuntimeConfig helper to detect future configs - Add incompatibleRuntime field to FrontendWorkspaceMetadata - Show error in AIView when workspace is incompatible - Add 'incompatible_workspace' SendMessageError type as fallback - Mark incompatible_workspace as non-retryable This prepares for #824 (Local/Worktree runtime distinction) by ensuring users can safely downgrade without losing access to their other workspaces.
ammar-agent
force-pushed
the
downgrade-compatibility-fix
branch
from
442a608 to
5e30b3a
Compare
ammar-agent
force-pushed
the
downgrade-compatibility-fix
branch
from
7ffc8f0 to
012e3c1
Compare
ammario
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prepares for #824 by ensuring users can safely upgrade→downgrade without losing access to their other workspaces.
When users upgrade to a version with new runtime types (like
type: "local"withoutsrcBaseDirfor project-dir mode, or newtype: "worktree") and then downgrade, the old version now shows a clear error instead of crashing.Changes
src/common/utils/runtimeCompatibility.tsisIncompatibleRuntimeConfig()helper (in common/ to avoid circular deps)src/common/types/workspace.tsincompatibleRuntimefield toFrontendWorkspaceMetadatasrc/node/config.tsincompatibleRuntimewhen loading workspace metadatasrc/browser/components/AIView.tsxsrc/browser/App.tsxincompatibleRuntimeto AIViewsrc/node/runtime/runtimeFactory.tsIncompatibleRuntimeErroras safety netsrc/node/services/ipcMain.tsIncompatibleRuntimeErrorin sendMessage (fallback)src/common/types/errors.tsincompatible_workspaceSendMessageError typeUser Experience
When clicking into an incompatible workspace, users see a centered error view:
Testing
isIncompatibleRuntimeConfig()createRuntime()throwing on incompatible configsGenerated with
mux