🤖 fix: persist status URL using storage.ts pattern #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add getStatusUrlKey to storage.ts with standard format - Register in PERSISTENT_WORKSPACE_KEY_FUNCTIONS for fork/delete - Add migrateWorkspaceStorage for rename support (fixes pre-existing bug) - Update StreamingMessageAggregator to use centralized key function Previously, status URLs used a non-standard key format and weren't migrated on workspace rename. Now all workspace storage keys are properly migrated when a workspace is renamed. _Generated with `mux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status URLs now use the standard storage.ts key pattern and are properly migrated on workspace rename.
Changes
getStatusUrlKeyto storage.ts with standard format (statusUrl:{workspaceId})PERSISTENT_WORKSPACE_KEY_FUNCTIONSfor fork/deletemigrateWorkspaceStoragefor rename support (fixes pre-existing bug where all workspace storage was lost on rename)StreamingMessageAggregatorto use centralized key functionWhy
Previously, status URLs used a non-standard key format (
mux:workspace:...) that wasn't registered in storage.ts, so:Generated with
mux