🤖 fix: show disabled voice button with HTTPS tooltip on insecure contexts #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
force-pushed
the
voice-input-mode
branch
2 times, most recently
from
7f81ec6 to
c39570a
Compare
ammar-agent
changed the title
navigator.mediaDevices is undefined in non-secure contexts (HTTP on non-localhost). Now shows a disabled mic button with tooltip explaining HTTPS is required, rather than hiding it entirely or crashing.
ammar-agent
force-pushed
the
voice-input-mode
branch
from
c39570a to
8b2306c
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated with mux
When accessing mux over HTTP (non-localhost),
navigator.mediaDevicesis undefined due to browser security restrictions. Previously this caused a crash or hidden button.Now shows a disabled mic button with tooltip: "Voice input requires a secure connection. Use HTTPS or access via localhost."
Changes:
requiresSecureContextflag touseVoiceInputhook