🤖 fix: preserve SSH host when switching runtime modes #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regression was introduced in 7087ef4 when adding Local/Worktree/SSH distinction. The onChange handler for runtime selection was changed from: mode === LOCAL ? '' : props.sshHost to: mode === SSH ? props.sshHost : '' This cleared the SSH host when switching away from SSH mode, losing the user's configured host when switching back. The fix stores the SSH host in a separate localStorage key (lastSshHost) that persists independently of the runtime mode. This ensures the SSH host is remembered when: 1. Switching from SSH → Local → SSH 2. Switching from SSH → Worktree → SSH _Generated with `mux`_
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
ammario
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression was introduced in 7087ef4 when adding Local/Worktree/SSH distinction. The onChange handler for runtime selection was changed from:
to:
This cleared the SSH host when switching away from SSH mode, losing the user's configured host when switching back.
Fix
The SSH host is now stored in a separate localStorage key (
lastSshHost:{projectPath}) that persists independently of the runtime mode. This ensures the SSH host is remembered when switching runtime modes:Testing
Generated with
mux