🤖 fix: change cancel edit keybind from Ctrl+Q to Escape #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ctrl+Q conflicts with system quit shortcut on Linux/Windows. New behavior: - Non-vim mode: Escape cancels edit - Vim mode: Escape goes to normal mode, second Escape cancels edit UI hints update dynamically based on vim mode: - Shows 'Esc to cancel' in non-vim mode - Shows 'Esc×2 to cancel' in vim mode _Generated with mux_
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
- Use formatKeybind(KEYBINDS.CANCEL_EDIT) consistently instead of hardcoded 'Esc' - Remove comment that repeated specific keybind values (brittle) - Add AGENTS.md note about not repeating constants in comments
ammar-agent
force-pushed
the
fix-cancel-edit-keybind
branch
from
a318f1c to
6905bf8
Compare
When entering edit mode, save current input text and image attachments. On cancel, restore both instead of leaving the edited message content.
ammar-agent
force-pushed
the
fix-cancel-edit-keybind
branch
from
6905bf8 to
43327ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ctrl+Q conflicts with system quit shortcut on Linux/Windows.
New behavior
Changes
escapeInNormalModeaction to vim state machineonEscapeInNormalModecallbackGenerated with
mux