🤖 fix: preserve existing GIT_SSH_COMMAND when set #861
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Instead of overwriting GIT_SSH_COMMAND entirely, append SSH options to the existing value. Falls back to 'ssh' if not set. _Generated with mux_
deansheather
force-pushed
the
fix/preserve-git-ssh-command
branch
from
5d990ee to
fc93bcb
Compare
There was a problem hiding this comment.
Pull request overview
This PR modifies the GIT_SSH_COMMAND environment variable to preserve any existing user-configured SSH commands instead of overwriting them entirely. The change appends SSH options (BatchMode=yes and StrictHostKeyChecking=accept-new) to the existing command or falls back to ssh if not set.
Key Changes:
- Updated
GIT_FETCH_SCRIPTto use shell parameter expansion for preserving existingGIT_SSH_COMMAND - Minor formatting adjustments in bump_tag.sh script
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/common/utils/git/gitStatus.ts | Modified GIT_SSH_COMMAND to preserve existing value using ${GIT_SSH_COMMAND:-ssh} pattern |
| scripts/bump_tag.sh | Removed spacing around redirection operators for consistent shell script formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of overwriting
GIT_SSH_COMMANDentirely, append SSH options to the existing value. Falls back tosshif not set.This allows users who have custom SSH commands configured (e.g., for specific identity files or proxy settings) to still benefit from our BatchMode and StrictHostKeyChecking options.
Generated with
mux