🤖 fix: subscribe to provider config changes for instant UI updates #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibetitsmike
force-pushed
the
fix-settings-update-delay
branch
from
c17e85d to
8a42d15
Compare
Use optimistic updates for immediate feedback when saving API keys, base URLs, and custom models. Subscription still exists for external changes (CLI, other components). Changes: - Add useProvidersConfig hook with optimistic update support - ProvidersSection updates UI immediately on save, persists in background - ModelsSection uses optimistic updates to avoid stale state races - ChatInput subscribes to config changes for OpenAI key status _Generated with `mux`_
ibetitsmike
force-pushed
the
fix-settings-update-delay
branch
from
8a42d15 to
8a52b4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings UI now reacts immediately when API keys or base URLs are saved.
Changes
useProvidersConfighook that subscribes to backendonConfigChangedeventsProvidersSection/ModelsSectionuse hook instead of manual refresh after saveChatInputsubscribes to config changes for OpenAI key status (voice input)Previously the UI would only update after manual refresh or component remount.
Now changes propagate instantly via the existing oRPC subscription mechanism.
Generated with
mux