🤖 Add macOS notarization support #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammario
force-pushed
the
add-macos-notarization
branch
2 times, most recently
from
5d9cc43 to
0012899
Compare
Collaborator
|
I added an Apple Connect API key for this instead of using someone's Apple ID directly. This way we know the scope of the key will always remain "Developer." A person's permission could change over time. You'll need to modify Relevant secrets are: |
- Configure electron-builder to notarize DMGs when credentials provided - Add environment variables for APPLE_ID, APPLE_APP_SPECIFIC_PASSWORD, APPLE_TEAM_ID - Notarization is optional - builds will succeed without credentials but skip notarization _Generated with `cmux`_
- Use API_KEY_ID, API_KEY_ISSUER_ID, API_KEY instead of Apple ID/password - API keys are more secure and don't expire like app-specific passwords _Generated with `cmux`_
- AC_APIKEY_ID - AC_APIKEY_ISSUER_ID - AC_APIKEY_P8_BASE64 (decoded to /tmp/AuthKey.p8) _Generated with `cmux`_
ammario
force-pushed
the
add-macos-notarization
branch
from
a653fea to
28e187e
Compare
- APPLE_API_KEY (path to .p8 file) - APPLE_API_KEY_ID - APPLE_API_ISSUER _Generated with `cmux`_
electron-builder will auto-detect credentials from env vars when notarize: true _Generated with `cmux`_
ammario
added a commit
that referenced
this pull request
Oct 8, 2025
Simplified installation instructions now that proper code signing and notarization are in place (from #90). ## Changes - **docs/install.md**: Removed all Gatekeeper bypass instructions (right-click → Open, terminal workarounds) - **docs/install.md**: Clarified separate x64 and arm64 artifact names - **README.md**: Updated to note signed/notarized status ## User Impact Users can now install cmux on macOS without any security warnings or workarounds. The app opens normally like any other Mac application. _Generated with `cmux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@spikecurtis - Secrets Added ✅
Spike has configured the App Store Connect API key secrets. This PR is ready to merge and test!
Problem
Current state:
When users download the DMG, macOS shows:
The app is properly signed, but requires notarization to pass Gatekeeper on modern macOS.
Solution
This PR adds notarization support using App Store Connect API keys (more secure than app-specific passwords):
Changes
1. Workflow updates (
.github/workflows/build.yml):API_KEY_ID,API_KEY_ISSUER_ID,API_KEYenvironment variables2. electron-builder config (
package.json):notarizeblock with team ID (4399GN35BJ)How it works
After merge
Once this merges:
Current build status
Latest main build (run #18325710712):
codesign --verify --deep --strictspctl -a -vvshows "Unnotarized Developer ID"Testing
After merge:
spctl -a -vv Cmux.appshould show "accepted" (not "rejected")Generated with
cmux