🤖 fix: use static mode for completed markdown to prevent render delay #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the ORPC migration, async event boundaries let React deprioritize Streamdown's useTransition() indefinitely, causing 10+ second delays for plan body rendering. Fix: Set mode='static' for completed content (parseIncompleteMarkdown=false) to bypass useTransition() and render immediately. This aligns with Streamdown's intended API usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes plan body taking 10+ seconds to render after the ORPC migration.
Root Cause
After ORPC, IPC events go through async iterators with microtask boundaries, giving React more opportunities to deprioritize Streamdown's
useTransition()indefinitely.Fix
Set
mode="static"for completed content (parseIncompleteMarkdown=false) to bypassuseTransition()and render immediately. This aligns with Streamdown's intended API:mode="streaming"- for incremental content, usesuseTransition()mode="static"- for complete content, renders immediatelyEven if this doesn't fully resolve the delay, the change is correct regardless - we were incorrectly using streaming mode for all content, including completed messages.
Generated with
mux