fix: build api CLI as ESM to support trpc-cli #926
Conversation
Adds a convenience target that runs the compiled CLI with trailing args: make mux server --port 4000 make mux -- --help Builds automatically if dist/cli/index.js is missing, otherwise instant.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ThomasK33
force-pushed
the
fix-esm-api-cli
branch
from
69ec91c to
c4f1f89
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ThomasK33
force-pushed
the
fix-esm-api-cli
branch
from
c4f1f89 to
886d917
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
trpc-cli requires ESM with top-level await, which can't be loaded via CommonJS require(). Bundle api.ts separately using esbuild as ESM (.mjs) and use native import() via Function constructor to bypass TypeScript's conversion to require(). Also adds `make mux` target for convenient CLI invocation.
ThomasK33
force-pushed
the
fix-esm-api-cli
branch
from
886d917 to
0818671
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
api.tsas ESM bundle (.mjs) using esbuild - trpc-cli requires ESM with top-level awaitimport()via Function constructor to bypass TypeScript's conversion torequire()make muxtarget for convenient CLI invocation (e.g.,make mux server --port 3000)Test plan
make mux -- api --helpworks (was broken before)make mux -- --helpworksmake mux run -- --helpworksmake mux server -- --helpworksmake lintpassesGenerated with mux