🤖 fix: prevent race condition when reloading with stale workspace #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
force-pushed
the
fix-workspace-reload-race-condition
branch
from
d251d30 to
a13fa3c
Compare
On page reload, selectedWorkspace is restored from localStorage synchronously during render, but workspace metadata is loaded asynchronously. If the selected workspace was deleted or the metadata hasn't loaded yet, rendering AIView with a non-existent workspace ID causes WorkspaceStore.assertGet() to throw. Fix: Guard against missing metadata before rendering AIView. If selectedWorkspace exists but currentMetadata is undefined, return null instead of rendering. The existing validation effect will clear the stale selection on the next tick. This also simplifies the code by removing unnecessary optional chaining since we now guard at the top of the conditional. _Generated with mux_
ammar-agent
force-pushed
the
fix-workspace-reload-race-condition
branch
from
a13fa3c to
19145ce
Compare
Root cause: WorkspaceContext's loadWorkspaceMetadata() returned early when api was null (during initial 'connecting' state), but setLoading(false) was still called. This caused App to render with empty metadata while selectedWorkspace was restored from localStorage, triggering the validation effect to clear the selection. Fix: - loadWorkspaceMetadata now returns boolean indicating if it actually loaded - Effect only calls setLoading(false) after successful load - When api becomes available, effect re-runs due to dependency change Also: - Removed redundant validation effect (lines 126-130) - the comprehensive one at lines 165-189 handles all cases including missing fields update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On page reload in Electron, the app fails to restore the previously selected workspace and instead shows the home page with this error:
Root Cause
Two race conditions were causing this:
1. API connection timing
WorkspaceContext'sloadWorkspaceMetadata()returned early whenapiwas null (during initial 'connecting' state), butsetLoading(false)was still called. This causedAppto render with empty metadata whileselectedWorkspacewas restored from localStorage, triggering the validation effect to clear the selection.2. Missing metadata guard
Even after fixing the API timing, if
selectedWorkspacefrom localStorage referred to a deleted workspace, theAIViewwould try to render before the validation effect could clear the stale selection.Solution
Wait for API:
loadWorkspaceMetadatanow returns a boolean indicating success. The effect only callssetLoading(false)after actual load. Whenapibecomes available, the effect re-runs.Guard AIView render: If
selectedWorkspaceexists butcurrentMetadatais undefined, returnnullinstead of renderingAIView. The validation effect will clear the stale selection on the next tick.Remove redundant effect: Removed the simple validation effect (lines 126-130) since the comprehensive one (lines 165-189) handles all cases including missing fields update.
Generated with
mux