🤖 fix: add loading state to ProjectContext to fix Storybook race #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SingleProject story sometimes failed to show workspace creation controls because of a race between two async operations: 1. ProjectContext loads projects via api.projects.list() 2. WorkspaceContext loads workspaces via api.workspace.list() When WorkspaceContext.loading became false, App would render but projects might still be empty (size 0), causing the condition `projects.size === 1` to be false, so creationProjectPath was null. Fix: Add a loading state to ProjectContext and gate on it in AppLoaderInner alongside workspaceContext.loading. _Generated with `mux`_
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SingleProject story sometimes failed to show workspace creation controls because of a race between two async operations:
api.projects.list()api.workspace.list()When
WorkspaceContext.loadingbecamefalse, App would render but projects might still be empty (size 0), causing the conditionprojects.size === 1to be false, socreationProjectPathwas null.Fix: Add a
loadingstate to ProjectContext and gate on it in AppLoaderInner alongsideworkspaceContext.loading.Generated with
mux