fix: use cygpath on Windows for temp dir path conversion #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, pwd in Git Bash returns Unix-style paths like /c/Users/... which Node's fs and spawn APIs misinterpret as C:\c\Users\... Use cygpath -w to convert to native Windows paths.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Member
Author
|
I think this breaks a bunch of stuff, so I'm closing.. Though this is definitely an issue, we're not cleaning up any of the tmp dirs. Opened #971. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On Windows,
createTempDirForStreamruns a shell command via Git Bash that returns a Unix-style path like/c/Users/ethan/.mux-tmp/854e934d.During cleanup, Node's
fs.access()andspawn()APIs misinterpret this path asC:\c\Users\...instead ofC:\Users\..., causing cleanup to fail:Fix
Use
cygpath -won Windows to convert thepwdoutput to native Windows path format (C:\Users\ethan\.mux-tmp\abc123), which Node APIs handle correctly.