Skip to content

Conversation

@ammar-agent
Copy link
Collaborator

Move LogLevel=ERROR outside the identityFile conditional so it applies to all SSH connections. This prevents SSH ControlMaster warnings like mux_client_request_session and ControlSocket already exists from appearing in git command output (e.g., as fake untracked files in the Review tab).

Also refactors exec() to use buildSSHArgs() helper, eliminating ~30 lines of duplicated SSH arg building code.

Generated with mux

Move LogLevel=ERROR outside the identityFile conditional so it applies
to all SSH connections. This prevents SSH ControlMaster warnings like
'mux_client_request_session' and 'ControlSocket already exists' from
appearing in git command output (e.g., as fake untracked files in the
Review tab).

Also refactors exec() to use buildSSHArgs() helper, eliminating ~30
lines of duplicated SSH arg building code.
@ammario ammario merged commit 6cdbfd1 into main Dec 8, 2025
18 checks passed
@ammario ammario deleted the review-tab-ssh-diffs branch December 8, 2025 18:16
ammar-agent added a commit that referenced this pull request Dec 8, 2025
The previous fix (#981) added LogLevel=ERROR to suppress SSH log messages,
but mux_client_request_session and ControlSocket warnings come from the
SSH multiplexing client code and write directly to stderr regardless of
log level.

This fix adds a TransformStream filter that removes these specific SSH
multiplexing messages from stderr before they reach consumers:
- mux_client_request_session: session request failed: Session open refused by peer
- ControlSocket ... already exists, disabling multiplexing
- Shared connection to ... closed.

These messages were appearing as fake untracked files in the Review tab
because git ls-files output was being polluted with SSH client noise.
ammar-agent added a commit that referenced this pull request Dec 8, 2025
The previous fix (#981) used LogLevel=ERROR, but mux_client_request_session
messages are at ERROR level in OpenSSH. Using LogLevel=FATAL suppresses
these while still showing fatal connection failures.
ammario pushed a commit that referenced this pull request Dec 8, 2025
The previous fix (#981) used `LogLevel=ERROR`, but
`mux_client_request_session` messages are at ERROR level in OpenSSH.

Using `LogLevel=FATAL` suppresses these while still showing fatal
connection failures.

## One-line fix
```diff
- args.push("-o", "LogLevel=ERROR");
+ args.push("-o", "LogLevel=FATAL");
```

_Generated with `mux`_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants