🤖 fix: add padding to bash tool SCRIPT section #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Added px-2 py-1.5 padding specifically to the Script DetailContent in BashToolCall (not globally to DetailContent, which would affect GenericToolCall's JSON display). Also added createBashTool mockFactory helper and WithBashTool story that expands a bash tool to visually validate the fix. _Generated with mux_
ammar-agent
force-pushed
the
bash-script-padding-fix
branch
from
490d559 to
ce436d0
Compare
ammario
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
px-2 py-1.5padding to theDetailContentcomponent which renders the Script section in the expanded bash tool view. This matches the padding used by the Output section andOutputPathscomponent.Also added:
createBashToolmockFactory helperWithBashToolstory that auto-expands a bash tool to visually validate the fixGenerated with
mux