🤖 fix: truncate oversized MCP images to prevent context overflow #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
ammar-agent
commented
Dec 9, 2025
Collaborator
Author
ammar-agent
left a comment
ammar-agent
left a comment
There was a problem hiding this comment.
The implementation uses indexOf("=") to find only the first = sign (line 164), so everything after it becomes the command:
--mcp "memory=npx -y @modelcontextprotocol/server-memory"
^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
name command (everything after first =)
The shell handles grouping via quotes. The help examples show this:
mux run --mcp "memory=npx -y @modelcontextprotocol/server-memory" "Remember this"
mux run --mcp "chrome=npx chrome-devtools-mcp" --mcp "fs=npx @anthropic/mcp-fs" "Take a screenshot"
Large base64-encoded images from MCP servers (like chrome-devtools-mcp screenshots) were overflowing the model's context window. - Extract mcpResultTransform module with 256KB limit for image data - Oversized images replaced with descriptive text message - Add MCP server support to `mux run` CLI command - Add comprehensive tests for image truncation logic _Generated with `mux`_
- Add --mcp flag: mux run --mcp "name=command" (can be repeated) - Add --no-mcp-config flag to ignore .mux/mcp.jsonc file - MCPServerManager accepts inlineServers and ignoreConfigFile options - Inline servers override config file servers with the same name - Add CLI tests for --mcp argument parsing and validation _Generated with `mux`_
ammar-agent
force-pushed
the
mcp-image-overflow-fix
branch
from
b68df88 to
3fdc8ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large base64-encoded images from MCP servers (like chrome-devtools-mcp screenshots) were overflowing the model's context window.
Changes
Image Overflow Fix
mcpResultTransformmodule with 256KB limit for image dataCLI MCP Support
mux runCLI command--mcpoption for inline server specification:mux run --mcp "name=command"--mcp server1=cmd1 --mcp server2=cmd2--no-mcp-configto ignore.mux/mcp.jsoncfileExamples
Testing
--mcpargument parsingGenerated with
mux