🤖 fix: workspace sidebar updates immediately on creation #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The useWorkspaceRecency hook was subscribed to states.subscribeAny, but
workspace recency is bumped via derived.bump("recency"). This caused a
delay between workspace creation and the sidebar reflecting the new
workspace.
Fixed by:
1. Adding subscribeDerived method that delegates to derived.subscribeAny
2. Updating useWorkspaceRecency to use subscribeDerived instead of subscribe
_Generated with mux_
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
useWorkspaceRecencyhook was subscribed tostates.subscribeAny, but workspace recency is bumped viaderived.bump("recency"). This caused a delay between workspace creation and the sidebar reflecting the new workspace.Root Cause
When a workspace is created:
addWorkspaceis called, which callsthis.derived.bump("recency")(line 731)useWorkspaceRecencywas subscribed tostore.subscribewhich delegates tostates.subscribeAnyderived, notstates, React wasn't notified of the changestatesbumpFix
subscribeDerivedmethod toWorkspaceStorethat exposesderived.subscribeAnyuseWorkspaceRecencyto usesubscribeDerivedinstead ofsubscribeNow when
derived.bump("recency")is called, the subscription fires immediately and React re-renders the sidebar with the new workspace.Generated with
mux