Skip to content

Conversation

@DevelopmentCats
Copy link
Contributor

Description

Type of Change

  • New module
  • New template
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/[namespace]/modules/[module-name]
New version: v1.0.0
Breaking change: [ ] Yes [ ] No

Template Information

Path: registry/[namespace]/templates/[template-name]

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun fmt)
  • Changes tested locally

Related Issues

@DevelopmentCats DevelopmentCats marked this pull request as ready for review October 16, 2025 19:08
@DevelopmentCats
Copy link
Contributor Author

@matifali

What do you think of this?

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How much time does this save on CI? Can we do something so that we run all tests if its on main?

@DevelopmentCats
Copy link
Contributor Author

DevelopmentCats commented Oct 16, 2025

LGTM. How much time does this save on CI? Can we do something so that we run all tests if its on main?

Realistically it would only save us around 15-60 seconds I think since a bulk of the time is spent on typescript tests when all are run

I've seen a weird variation in ci run time for the validation step in other runs so its hard to estimate

@DevelopmentCats DevelopmentCats merged commit ff09c41 into main Oct 16, 2025
4 checks passed
@DevelopmentCats DevelopmentCats deleted the cat/tftest-rework branch October 16, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants