Skip to content

fix: improve version extraction logic to prevent false positives #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 31, 2025
Merged

fix: improve version extraction logic to prevent false positives #511

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
faa11ff
fix: improve version extraction logic to prevent false positives
DevelopmentCats Oct 24, 2025
c6dabc6
fix(version-bump): remove redundant checks
DevelopmentCats Oct 27, 2025
4547844
Merge branch 'main' into cat/version-bump-fix
DevelopmentCats Oct 27, 2025
66911c6
Merge branch 'main' into cat/version-bump-fix
DevelopmentCats Oct 27, 2025
f845a23
Merge branch 'main' into cat/version-bump-fix
matifali Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/scripts/version-bump.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,16 +77,19 @@ update_readme_version() {
in_target_module = 0
}
}
/version.*=.*"/ {
/^[[:space:]]*version[[:space:]]*=/ {
if (in_target_module) {
gsub(/version[[:space:]]*=[[:space:]]*"[^"]*"/, "version = \"" new_version "\"")
match($0, /^[[:space]]*/
indent = substr($0, 1, RLENGTH)
print indent "version = \"" new_version "\""
in_target_module = 0
next
}
}
{ print }
' "$readme_path" > "${readme_path}.tmp" && mv "${readme_path}.tmp" "$readme_path"
return 0
elif grep -q 'version\s*=\s*"' "$readme_path"; then
elif grep -q '^[[:space:]]*version[[:space:]]*=' "$readme_path"; then
echo "⚠️ Found version references but no module source match for $namespace/$module_name"
return 1
fi
Expand Down Expand Up @@ -148,9 +151,9 @@ main() {
local current_version

if [ -z "$latest_tag" ]; then
if [ -f "$readme_path" ] && grep -q 'version\s*=\s*"' "$readme_path"; then
if [ -f "$readme_path" ] && grep -q '^[[:space:]]*version[[:space:]]*=' "$readme_path"; then
local readme_version
readme_version=$(grep 'version\s*=\s*"' "$readme_path" | head -1 | sed 's/.*version\s*=\s*"\([^"]*\)".*/\1/')
readme_version=$(awk '/^[[:space:]]*version[[:space:]]*=/ { match($0, /"[^"]*"/); print substr($0, RSTART+1, RLENGTH-2); exit }' "$readme_path")
echo "No git tag found, but README shows version: $readme_version"

if ! validate_version "$readme_version"; then
Expand Down