Skip to content

Conversation

@uzair-coder07
Copy link
Contributor

@uzair-coder07 uzair-coder07 commented Oct 29, 2025

Description

This PR adds an enhancement to the Sourcegraph module to explicitly require the "external" Terraform provider. Currently, The module makes use of the external provider from Terraform but doesn't explicitly require it. It uses the external provider on line 158 within the module source code here

Type of Change

  • Fix/Enhancement

Module Information

Path: registry/coder-labs/modules/sourcegraph-amp
Breaking change: No

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun fmt) - bun fmt errors out with the following:
    [error] Cannot find package 'prettier-plugin-sh' imported from /Users/mohammeduzair/coder-learn/coder-minimal/registry-test/registry/noop.js error: script "fmt" exited with code 1
  • Changes tested locally

Related Issues

None

@uzair-coder07
Copy link
Contributor Author

Hey @matifali! I have seen that you have worked on the coder-registry. Please help in reviewing this. This was raised by a customer on ticket 4570. bun fmt failed on my system and I have pasted the error message - That is why the CI check is failing. If you have information on how I can fix it, That would be greatly appreciated. Thanks!

@uzair-coder07
Copy link
Contributor Author

Ah, I was able to run bun fmt successfully. My bad, I didn't install a plugin required for bun fmt. Looks like the checks are passing now. Please let me know if you need anything before merging. Thanks!

@rowansmithau rowansmithau added the version:patch Add to PRs requiring a patch version upgrade label Oct 29, 2025
@matifali
Copy link
Member

Looks good to me. Thanks Uzair.

@matifali
Copy link
Member

Can you fix the commit authorship? It's currently linked to an unknown user.

@uzair-coder07 uzair-coder07 force-pushed the fix/sourcegraph-module branch from 2b68f9e to b9adec1 Compare October 30, 2025 03:31
@uzair-coder07 uzair-coder07 force-pushed the fix/sourcegraph-module branch from b9adec1 to 1ff5e24 Compare October 30, 2025 03:37
@uzair-coder07
Copy link
Contributor Author

Can you fix the commit authorship? It's currently linked to an unknown user.

Fixed it. Thanks for checking that.

@matifali matifali changed the title Fix Sourcegraph module (explicitly require external provider) fix(coder-labs/modules/sourcegraph-amp): explicitly require external provider Oct 30, 2025
@matifali matifali merged commit 0ce65b2 into main Oct 30, 2025
4 checks passed
@matifali matifali deleted the fix/sourcegraph-module branch October 30, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:patch Add to PRs requiring a patch version upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants