-
Notifications
You must be signed in to change notification settings - Fork 76
fix(coder/modules/claude-code): move set -euo pipefail after sourcing .bashrc
#520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Moves the strict error handling flags after sourcing user bashrc files to prevent failures from unbound variables in user dotfiles. This is especially important when users load dotfiles from git. Fixes agentapi server startup failures caused by BASHRCSOURCED and other unbound variables in /etc/bashrc or user-specific bashrc files.
set -euo pipefail after sourcing bashrc
set -euo pipefail after sourcing bashrcset -euo pipefail after sourcing .bashrc
|
@matifali @DevelopmentCats This line in the bashrc prevents sourcing the bash script if we are in non-interactive mode |
Wow you are totally right about this, Great Catch! So basically right now those lines are essentially doing nothing haha. |
|
I guess then it's good to merge? |
|
Yup, The other modules that are working right now, are due to the other exports that we have along sourcing of the bash file. |
@35C4n0r, please feel free to go through all of them to fix this. |
Moves the strict error handling flags after sourcing user bashrc files to prevent failures from unbound variables in user dotfiles. This is especially important when users load dotfiles from git.
Fixes agentapi server startup failures caused by BASHRCSOURCED and other unbound variables in
/etc/bashrcor user-specific bashrc files.