feat: enhance version bump script and CI workflow with ci mode #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevelopmentCats
added
the
version:patch
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the version bump automation by adding a CI mode to the version bump script that produces cleaner, less verbose output when validation fails. The changes streamline the GitHub Actions workflow and improve the developer experience when version bumps are required.
Key changes:
- Adds
--ciflag to version-bump.sh script for automated validation mode - Simplifies CI workflow by removing complex output handling and using direct script execution
- Optimizes formatting to only process modified README files instead of the entire repository
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| registry/coder/modules/code-server/main.tf | Test comment added (should be removed before merge) |
| registry/coder/modules/code-server/README.md | Version references updated from 1.4.1 to 1.4.2 |
| .github/workflows/version-bump.yaml | Simplified workflow to use CI mode, cleaner failure comment |
| .github/scripts/version-bump.sh | Added CI mode flag, optimized formatting, updated loop condition |
DevelopmentCats
added
version:patch
Contributor
❌ Version Bump RequiredOne or more modules in this PR need their versions updated. To fix this:
The CI will automatically re-run once you push the updated versions. |
DevelopmentCats
force-pushed
the
cat/version-bump-ci-mode
branch
from
2e1fe5d to
862bd9a
Compare
DevelopmentCats
added
version:patch
DevelopmentCats
force-pushed
the
cat/version-bump-ci-mode
branch
from
862bd9a to
aebdfb7
Compare
DevelopmentCats
added
version:patch
Contributor
Version Bump RequiredOne or more modules in this PR need their versions updated. To fix this:
The CI will automatically re-run once you push the updated versions. |
DevelopmentCats
removed
the
version:patch
- Add --ci flag to version-bump.sh for CI validation - CI mode runs version bump, formats files, then checks git diff - Exit 0 if no changes (versions already correct), exit 1 if changes needed - Update workflow to use --ci flag and post cleaner failure comment - Fix awk script to avoid adding extra blank lines - Run prettier on modified README files for consistent formatting
DevelopmentCats
force-pushed
the
cat/version-bump-ci-mode
branch
from
aebdfb7 to
eb05374
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add CI mode to version bump script to output Pass or Fail with a less verbose comment when it fails
Type of Change
Testing & Validation
bun test)bun fmt)Related Issues